674453712be8b

674453712d6f9
7 Guests are here.
 

Topic: SS2 Blue Mod Manager
Page: « 1 ... 17 [18] 19 ... 22 »
Read 43763 times  

674453712e786voodoo47

Re: Re: SS2 Blue Mod Manager
674453712e8ac
hmm, doesn't seem like the gamesys mod gets moved to the lowest priority spot if set incorrectly - I was expecting it would pop to the proper place once I hit the Apply button. or should I be looking at something else?
Re: Re: SS2 Blue Mod Manager
674453712ed3c
Oh, just when you activate it. It doesn't auto-apply to current config.

674453712eec4voodoo47

Re: Re: SS2 Blue Mod Manager
674453712efd8
ah, I see - so a regular mod, when activated, is assigned a top active spot, while a gamesys mod is assigned the lowest active spot. I'm ok with this.
Re: Re: SS2 Blue Mod Manager
674453712f2f1
User must still be able to override whatever the manager has in mind. One could additionally also reorder when any mod is activated. Could be annoying though.

674453712f3bdvoodoo47

Re: Re: SS2 Blue Mod Manager
674453712f433
yeah, this is pretty ok, as I've said. or to be precise, I don't have any idea how to make it better.
Re: Re: SS2 Blue Mod Manager
674453712f90f
Still no warning at all. Also no "Issue detected" thingy for duplicate folders (could be implemented)
In the ss2bmm.log I can even see the duplicate folders.
Re: Re: SS2 Blue Mod Manager
674453712fc1a
I fear that Wine emulates case-insensitivity in certain parts and neglects to do so for others, or that's at least what I gather from several internet posts (including some about mod troubles, ironically). This is the code in the manager:
Code: [Select]
std::list<std::string> allSubDirs;
wxString nextDirName;
wxString currentDirName;
bool isDirFound = dir.GetFirst(&nextDirName, wxEmptyString, wxDIR_DIRS | wxDIR_HIDDEN);
while (isDirFound)
{
currentDirName = wxString(nextDirName).MakeLower();
// go through all folders and collect for later case-sensitive check
allSubDirs.push_back(currentDirName.ToStdString());

// check existence of any data directory
for (auto& dirName : dataDirectories_)
{
if (dirName.compare(currentDirName) == 0)
mod.setHasOther(true);
}

isDirFound = dir.GetNext(&nextDirName);
}

// Wine-only check
if (!allSubDirs.empty()) {
unsigned int dirNumberIncludingNonUnique = allSubDirs.size();
allSubDirs.unique();
if (dirNumberIncludingNonUnique != allSubDirs.size())
mod.setHasDuplicateFolders(true);
}
Since wxWidgets uses Windows API calls, dir.GetNext() could very well yield any folder only once irregardless of case.
« Last Edit: 17. November 2020, 11:35:56 by Marvin »
Re: Re: SS2 Blue Mod Manager
6744537130257
Note: Did not abandon again, just need a free weekend at some point... fingers crossed.
Acknowledged by: voodoo47

6744537130404voodoo47

Re: Re: SS2 Blue Mod Manager
6744537130564
we may want to make the manager complain a bit if two mods which include the same mission/map are active at the same time - I don't think there is a situation where a regular user would want to do this. just a warning would suffice, "you better be sure you know what you are doing there"..
Acknowledged by 2 members: ZylonBane, Marvin
Re: Re: SS2 Blue Mod Manager
6744537130822
Ok. Finally found some time to get back to it.
Acknowledged by: voodoo47
Re: Re: SS2 Blue Mod Manager
67445371310f3
Currently adding:
* Basic drag&drop support
* Profiles

Will include map overwrite warnings as well. If you've got any ideas what other kinds of validation you'd want, now would be a good time as I'd like to update that part anyway.

Looked into mod groups but decided against implementing them: Basically requires a full rewrite of the main GUI code. If this project was redone in 2020, you'd just build a browser SPA, add some basic JS and CSS and be done with it. This super-specific GUI framework code is ridiculous.

6744537131253voodoo47

Re: Re: SS2 Blue Mod Manager
674453713190e
very simple, two maps with the same filename are active = warning.
« Last Edit: 16. November 2020, 23:59:09 by voodoo47 »

6744537131e31ZylonBane

Re: Re: SS2 Blue Mod Manager
67445371327d8
Does it already warn on multiple mods with a *.GAM file?
Re: Re: SS2 Blue Mod Manager
6744537134080
very simple, two maps with the same filename are active = warning.
Ehm, yes, that's what I meant by "map overrides".
Does it already warn on multiple mods with a *.GAM file?
Yes.

6744537134150voodoo47

Re: Re: SS2 Blue Mod Manager
67445371341a8
ah, missed the "other" bit there. good to go then.
Re: Re: SS2 Blue Mod Manager
6744537134681
Next test:
* Drag and drop support added
* Profile manager added: Nothing fancy such as hashed directory comparisons. Writes mod_path attribute to file and loads it when imported. Therefore does not work if (relative) mod directories change. Hopefully good enough.
* Warning for multiple mis files added.
* Various other bug fixes
[ss2bmm.exe expired]
« Last Edit: 06. December 2020, 15:15:11 by Marvin »
Acknowledged by: voodoo47
Re: Re: SS2 Blue Mod Manager
6744537134d7d
Updated again cause previous mis file check only worked with two mis mods in total.

6744537134e1dvoodoo47

Re: Re: SS2 Blue Mod Manager
6744537134e6e
I will test this later this week.
Re: Re: SS2 Blue Mod Manager
6744537134f6f
That's fine. I might add some stuff/fixes, so probably download the manager when you actually start testing just to be sure.
Acknowledged by: voodoo47
Re: Re: SS2 Blue Mod Manager
674453713508e
Project is now hosted on GitHub: https://github.com/pshjt/ss2bmm
Acknowledged by: Kolya

674453713517bvoodoo47

Re: Re: SS2 Blue Mod Manager
67445371351cc
finally some time to check things out. map mods (just mis files) now show as unrecognized (ok with 1.15, and even some of the older 1.16 betas). maybe "only one mod with mis files should be active" would be better than "do not use mods with overlapping mis files".
[bmm_wip.jpg expired]
Re: Re: SS2 Blue Mod Manager
67445371352dc
Good catch. Updated exe.
I like the message as it is better because it correctly explains what is going on. You can have different mis mods active, only not with overlapping mis files. Granted, it's very unlikely to have such a setup...

674453713536fvoodoo47

Re: Re: SS2 Blue Mod Manager
67445371353c6
do not underestimate the capabilities of a pokemon mod collector.
Re: Re: SS2 Blue Mod Manager
67445371354c8
Any comments about the profile manager? That's the one thing I would expect the most issues to crop up with.

If that's good to go, I would only update the icons for the profile manager and that's it.

Your name:
This box must be left blank:

TriOptimum counter-terrorism consultant Rebecca ____ (Fill in the last name):
7 Guests are here.
The Focus delivers electricity straight to your brain, gleaning neuroplasticity and increasing your hacking skills...supposedly.
Contact SMF 2.0.19 | SMF © 2016, Simple Machines | Terms and Policies
FEEP
67445371363ec