67445736d27ae

67445736d3ba3
4 Guests are here.
 

Topic: SS2 Blue Mod Manager
Page: « 1 ... 17 [18] 19 ... 22 »
Read 43773 times  

67445736d4458voodoo47

Re: Re: SS2 Blue Mod Manager
67445736d44ea
hmm, doesn't seem like the gamesys mod gets moved to the lowest priority spot if set incorrectly - I was expecting it would pop to the proper place once I hit the Apply button. or should I be looking at something else?
Re: Re: SS2 Blue Mod Manager
67445736d48e1
Oh, just when you activate it. It doesn't auto-apply to current config.

67445736d49f5voodoo47

Re: Re: SS2 Blue Mod Manager
67445736d4a5a
ah, I see - so a regular mod, when activated, is assigned a top active spot, while a gamesys mod is assigned the lowest active spot. I'm ok with this.
Re: Re: SS2 Blue Mod Manager
67445736d4b9e
User must still be able to override whatever the manager has in mind. One could additionally also reorder when any mod is activated. Could be annoying though.

67445736d4c6avoodoo47

Re: Re: SS2 Blue Mod Manager
67445736d4cc4
yeah, this is pretty ok, as I've said. or to be precise, I don't have any idea how to make it better.
Re: Re: SS2 Blue Mod Manager
67445736d4ecf
Still no warning at all. Also no "Issue detected" thingy for duplicate folders (could be implemented)
In the ss2bmm.log I can even see the duplicate folders.
Re: Re: SS2 Blue Mod Manager
67445736d5098
I fear that Wine emulates case-insensitivity in certain parts and neglects to do so for others, or that's at least what I gather from several internet posts (including some about mod troubles, ironically). This is the code in the manager:
Code: [Select]
std::list<std::string> allSubDirs;
wxString nextDirName;
wxString currentDirName;
bool isDirFound = dir.GetFirst(&nextDirName, wxEmptyString, wxDIR_DIRS | wxDIR_HIDDEN);
while (isDirFound)
{
currentDirName = wxString(nextDirName).MakeLower();
// go through all folders and collect for later case-sensitive check
allSubDirs.push_back(currentDirName.ToStdString());

// check existence of any data directory
for (auto& dirName : dataDirectories_)
{
if (dirName.compare(currentDirName) == 0)
mod.setHasOther(true);
}

isDirFound = dir.GetNext(&nextDirName);
}

// Wine-only check
if (!allSubDirs.empty()) {
unsigned int dirNumberIncludingNonUnique = allSubDirs.size();
allSubDirs.unique();
if (dirNumberIncludingNonUnique != allSubDirs.size())
mod.setHasDuplicateFolders(true);
}
Since wxWidgets uses Windows API calls, dir.GetNext() could very well yield any folder only once irregardless of case.
« Last Edit: 17. November 2020, 11:35:56 by Marvin »
Re: Re: SS2 Blue Mod Manager
67445736d520d
Note: Did not abandon again, just need a free weekend at some point... fingers crossed.
Acknowledged by: voodoo47

67445736d5316voodoo47

Re: Re: SS2 Blue Mod Manager
67445736d537d
we may want to make the manager complain a bit if two mods which include the same mission/map are active at the same time - I don't think there is a situation where a regular user would want to do this. just a warning would suffice, "you better be sure you know what you are doing there"..
Acknowledged by 2 members: ZylonBane, Marvin
Re: Re: SS2 Blue Mod Manager
67445736d5499
Ok. Finally found some time to get back to it.
Acknowledged by: voodoo47
Re: Re: SS2 Blue Mod Manager
67445736d565a
Currently adding:
* Basic drag&drop support
* Profiles

Will include map overwrite warnings as well. If you've got any ideas what other kinds of validation you'd want, now would be a good time as I'd like to update that part anyway.

Looked into mod groups but decided against implementing them: Basically requires a full rewrite of the main GUI code. If this project was redone in 2020, you'd just build a browser SPA, add some basic JS and CSS and be done with it. This super-specific GUI framework code is ridiculous.

67445736d5710voodoo47

Re: Re: SS2 Blue Mod Manager
67445736d576e
very simple, two maps with the same filename are active = warning.
« Last Edit: 16. November 2020, 23:59:09 by voodoo47 »

67445736d58c0ZylonBane

Re: Re: SS2 Blue Mod Manager
67445736d5920
Does it already warn on multiple mods with a *.GAM file?
Re: Re: SS2 Blue Mod Manager
67445736d5e9c
very simple, two maps with the same filename are active = warning.
Ehm, yes, that's what I meant by "map overrides".
Does it already warn on multiple mods with a *.GAM file?
Yes.

67445736d5f6fvoodoo47

Re: Re: SS2 Blue Mod Manager
67445736d5fcc
ah, missed the "other" bit there. good to go then.
Re: Re: SS2 Blue Mod Manager
67445736d614e
Next test:
* Drag and drop support added
* Profile manager added: Nothing fancy such as hashed directory comparisons. Writes mod_path attribute to file and loads it when imported. Therefore does not work if (relative) mod directories change. Hopefully good enough.
* Warning for multiple mis files added.
* Various other bug fixes
[ss2bmm.exe expired]
« Last Edit: 06. December 2020, 15:15:11 by Marvin »
Acknowledged by: voodoo47
Re: Re: SS2 Blue Mod Manager
67445736d79e1
Updated again cause previous mis file check only worked with two mis mods in total.

67445736d7ac9voodoo47

Re: Re: SS2 Blue Mod Manager
67445736d7b1e
I will test this later this week.
Re: Re: SS2 Blue Mod Manager
67445736d7c36
That's fine. I might add some stuff/fixes, so probably download the manager when you actually start testing just to be sure.
Acknowledged by: voodoo47
Re: Re: SS2 Blue Mod Manager
67445736d7d4d
Project is now hosted on GitHub: https://github.com/pshjt/ss2bmm
Acknowledged by: Kolya

67445736d7e42voodoo47

Re: Re: SS2 Blue Mod Manager
67445736d7e8f
finally some time to check things out. map mods (just mis files) now show as unrecognized (ok with 1.15, and even some of the older 1.16 betas). maybe "only one mod with mis files should be active" would be better than "do not use mods with overlapping mis files".
[bmm_wip.jpg expired]
Re: Re: SS2 Blue Mod Manager
67445736d7f92
Good catch. Updated exe.
I like the message as it is better because it correctly explains what is going on. You can have different mis mods active, only not with overlapping mis files. Granted, it's very unlikely to have such a setup...

67445736d8029voodoo47

Re: Re: SS2 Blue Mod Manager
67445736d8077
do not underestimate the capabilities of a pokemon mod collector.
Re: Re: SS2 Blue Mod Manager
67445736d817e
Any comments about the profile manager? That's the one thing I would expect the most issues to crop up with.

If that's good to go, I would only update the icons for the profile manager and that's it.

Your name:
This box must be left blank:

In which year was System Shock released:
4 Guests are here.
Looking Glass didn’t just want to move the needle, they wanted to break the scale.
Contact SMF 2.0.19 | SMF © 2016, Simple Machines | Terms and Policies
FEEP
67445736d8fd6