SS2 Unstable Grenades mod

[67359dbc091c4sarge945]

The metaprop is definitely the right way to go.

[67359dbc09373ZylonBane]

That's great, but I'd still like to know why what should be identical operations are having different results.

[67359dbc0958cvoodoo47]

assigning props via dml works 99% the same as applying them in the editor. this is the 1%, a dml quirk you have to be aware of else there will be issues. just like when you change the class tags/schema of a concrete object - no issues when changed in the editor, but if you do it via dml, you will have to save and reload at least once when playing the game for the change to be fully applied.

I was aware that something like this is going on (that's why my dmls stomp on empty script slots), but lacked the last piece of puzzle (the Grenades object, which by default doesn't have any scripts) which you now have provided - I will mention this peculiarity in the dml guide, I just need to give it some form that would be understandable by human beings.

[67359dbc096d7ZylonBane]

Maybe when the DML processor automatically adds the script property before modifying it, it's copying the inherited script property, resulting in script duplication. I'll have to do some testing.

[67359dbc0982bvoodoo47]

well.. sure, but I'm positive the only thing we can really do here is to describe the scenario thoroughly and file it under just don't.

[67359dbc09a50ZylonBane]

Confirmed in DromEd, adding a Script object via DML duplicates the inherited script object. This is actually normal behavior in DromEd when adding most properties, whether it's a runtime inherited property or not. A handful of properties seem to be internally excepted from this copying, like the Script property. The DML processor apparently doesn't respect this flag or however it's implemented.

So... not sure if bug or intentional.

Anyway, fixed by moving to a metaprop. Mod updated. Removed your post advising to edit the DML so there isn't conflicting advice in the mod thread. Correct course of action is update the mod, not hack the mod.

[67359dbc09bc7voodoo47]

and dml guide updated with the info.

also there is no sane scenario where you'd want script duplication to happen (editor or not), so this is unintended functionality at best, I'd say - remember, we had to fix quite a few instances of duplicate scripts both on the archetypes and concretes, very likely this has happened because the original mappers weren't aware of this and caused the duplication when adding the prop.

[67359dbc09cddZylonBane]

I see you've described "the DML loader will copy the inherited script property" in an impressively verbose way.

[67359dbc09defvoodoo47]

a master of eloquence, I ain't. feel free to edit and simplify.