SCP Verbesserte Deutsche Übersetzung + SCP problem

[673fc9ebdef25JML]

Ich habe nichts händisch in den Mod-Archiven gerumgepfuscht. Meine modlist ist relativ groß, aber meines Erachtens sollte da nicht die objlooks.str mit objname.str überschrieben werden. Sieh selbst! (Passt die Reihenfolge?)
[7Stueck.png expired]
[modmanager2.PNG expired]
[ss2bmm.log expired]

[673fc9ebdf22eMarvin]

Die Sortierung ist in Ordnung. Ist das Archiv beschädigt? Kannst du mal den SCP_deutsch-Ordner zippen und hochladen?

[673fc9ebdf331JML]

Bitte gerne:
[SCP_deutschv08.7z expired]

[673fc9ebdf41bMarvin]

Okay, da stimmt alles. Was passiert, wenn du nur diese Mod deaktivierst?

[673fc9ebdf510JML]

Etwas fürchterliches. Es dürfte somit eine andere Mod hier reinpfuschen. Huch das dürfte komplizierter werden:
[13slugs.png expired]

[673fc9ebdf673Marvin]

Da ist mit hoher Warhscheinlichkeit etwas mit dem Spiel selbst nicht in Ordnung. Schon einmal mit einer Neuinstallation + SS2Tool versucht? Wenn auch das nicht hilft, solltest du einen Thread im Helpdesk eröffnen, denn das wäre schon ein sehr seltsamer Bug.

[673fc9ebdf775JML]

Die CDs liegen bei meinem Bruder. Ich könnte eine Neuinstallation mit der Steam Version probieren.

[673fc9ebdf85aMarvin]

Kannst auch SS2Tool im Perfect-Mode probieren, aber ich weiß nicht, ob das wirklich absolut jede Datei checkt.

[673fc9ebdf9cavoodoo47]

pretty sure this is happening because whoever made the string modification used OBJNAME.STR (%d will display the current stack count of the item) description in OBJLOOKS.STR (text only). find the OBJLOOKS.STR that contains text with %d and you'll find the source of the problem.

[673fc9ebdfaf2Marvin]

Yeah, but no mod on that list does that, including mine. In any case, that kind of error should have been overwritten both by SCP and my mod. The fact it's still there means SS2 reads from objname instead of objlooks OR, for some bizarre reason, loads both simultaneously and chooses the entry from objname which has the same name, except for upper case letters.

[673fc9ebdfe05voodoo47]

SS2 reads from objname instead of objlooks

this happens when OBJLOOKS.STR is missing or corrupted. and I can always dissect the game install if you upload it somewhere (or perhaps try to replicate myself, I think I can get the DE version via GOG).

//quickly loaded the v8 translation from this topic over my EN version (max priority), and the text is fine.

[673fc9ebdff54Marvin]

As you joined the conversation later, mods have already been ruled out, must be something with the installation. And I doubt Steam or GOG are to blame, otherwise we'd be in trouble.

[673fc9ebe0046voodoo47]

yes, confirming that GOG DE + SS2tool + Deutsche-Übersetzung + V8 works fine. still up for that dissection if nothing else is found.

[673fc9ebe01a2JML]

I deleted the zipped mods, the cutscenes, the extra content and the screenshots and zipped up my whole SS2 folder. I just realized that this is a Steam install patched in Perfect mode with one of the latest SSTools (6.1.1.5 around december) and then patched in update mode with the latest one (last week; same version number) . The path to it was "D:\Games\SS2" so I don't assume the path length is the problem.
I compressed the SS2 folder with 7z, setting is ultra, so it might take a bit to unzip, but it's relatively small (2,25GB -> 1,2GB). Enjoy!

[673fc9ebe028evoodoo47]

got it, and link removed - also yeah, it's happening on my pc now as well, so time to cut this into bits.

[673fc9ebe03cbvoodoo47]

allright guys, you can put your strings down, this is an extremely edge case SCP bug - well, not sure whether it should be called a bug, but it's being caused by the (ADaoB) hybrid shotgun single slug fix. it will manifest only if you pick up a single hybrid slug while not having any normal slugs in your inventory - and then the stack will fail to acquire the description properly. to fix this, drop the failed stack, pick up a few normal slugs (from a container, replicator, whatever), and then pick the failed stack again.

will be fixed in the upcoming SCP b4, most likely.

[673fc9ebe04abJML]

Nice work in such a short time. Gute Arbeit, mein Herr!

[673fc9ebe0624voodoo47]

I ain't done yet - looks like I spoke to soon, and it's time to pick the strings up again, edit OBJLOOKS.STR and add

onerifledslug: "Whatever text you desire"

and be amazed.

[673fc9ebe08eeZylonBane]

Interesting. This seems to be caused by a fun combination of engine features:
- Multiple objects can be set to combine into the same inventory stack when picked up, but the specific object in your inventory will be based on the first object of a particular category that you pick up.
- If you don't explicitly specify an object's look, short, or name string in the gamesys, it tries to automatically find the correct string based on the object's name in the hierarchy.
- When you examine an inventory object, it first tries to find and display a string from objlooks.str. If that fails, it falls back to objname.str.
- Certain strings are formatted to have dynamic data substituted into them, like the stack count. But if the code printing one of these strings doesn't provide this data, the string is printed as-is.

In the object hierarchy, the standard box of rifled slugs is named "Rifled Slug Box" and has a stack count of 6.  Importantly, "Rifled Slug Box" explicitly specifies its name string, but not its look (long description) string. ADaOB added (and SCP carried over) a descendant of this object named "OneRifledSlug", which inherits everything from its parent except the stack count, which it sets to 1.

So here's what's happening when you loot a shotgun hybrid for your first rifled slug shotgun shell:
1) The rifled slug inventory object is set to an instance of "OneRifledSlug".
2) When you attempt to examine this inventory item, the engine checks its object hierarchy entry for a look string. It doesn't find one, so...
3) It looks in objlooks.str for a "OneRifledSlug" string entry. It doesn't find one, so...
4) It checks the object hierarchy for a name string. It does find one (inherited from its parent object), so goes to display that, But...
5) The string has a stack count in it, which the description panel code doesn't know about, so you see the %d.

TL;DR, the fix is super simple: Add a property to the base "Rifled Slug Box" object that explicitly identifies "rifled_slug_box" in objlooks.str as its long description.

[673fc9ebe0a16voodoo47]

right - attaching a dml that will fix the issue without any string edits. its safe to stick it into the translation, if you don't want to wait for SCP b4.

//attach removed - SS2tool update is up, whoever patches up from this point on will not have this problem.

[673fc9ebe0babZylonBane]

Code: [Select]

+ObjProp "Rifled Slug Box" "ObjLookS" = "Rifled_Slug_Box: "Rifled slugs""The DML parser will interpret those nested double quotes correctly?

You don't even need to include a default string anyway since we know for a fact that that string exists.

[673fc9ebe0ca2voodoo47]

yes it will, I've checked, but ok, will shorten it.

[673fc9ebe0d9fMarvin]

So, no need to do anything. Thanks for the clarification. If possible, the topic could be split off from here and merged with SCP issues.

[673fc9ebe0e87voodoo47]

ok, splitting off, but no need to merge, I think.

//SS2tool update is up, whoever patches up from this point on will not have this problem.